- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.7k
 
[v14.x] src,doc,test: add --openssl-shared-config option #43782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
                
     Closed
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           Review requested: 
  | 
    
    
  RafaelGSS 
      pushed a commit
        to RafaelGSS/node
      that referenced
      this pull request
    
      Jul 11, 2022 
    
    
      
  
    
      
    
  
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: nodejs#43124 Refs: nodejs#40366 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Backport-PR-URL: nodejs#43782
58adec0    to
    7ccd8ef      
    Compare
  
    
              
                    BethGriggs
  
              
              reviewed
              
                  
                    Jul 11, 2022 
                  
              
              
            
            
    
  RafaelGSS 
      pushed a commit
        to RafaelGSS/node
      that referenced
      this pull request
    
      Jul 11, 2022 
    
    
      
  
    
      
    
  
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: nodejs#43124 Refs: nodejs#40366 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Backport-PR-URL: nodejs#43782
7ccd8ef    to
    af97af1      
    Compare
  
    
              
                    mcollina
  
              
              approved these changes
              
                  
                    Jul 12, 2022 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: nodejs#43124 Refs: nodejs#40366 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Backport-PR-URL: nodejs#43782
af97af1    to
    b4f8dac      
    Compare
  
    
              
                    BethGriggs
  
              
              approved these changes
              
                  
                    Jul 13, 2022 
                  
              
              
            
            
              
                    richardlau
  
              
              approved these changes
              
                  
                    Jul 13, 2022 
                  
              
              
            
            
| 
           Removing   | 
    
| 
           Landed in ea48c30  | 
    
    
  RafaelGSS 
      pushed a commit
      that referenced
      this pull request
    
      Jul 21, 2022 
    
    
      
  
    
      
    
  
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: #43124 Refs: #40366 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Backport-PR-URL: #43782 Refs: nodejs/nodejs.org#4713 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    c++
  Issues and PRs that require attention from people who are familiar with C++. 
  
    needs-ci
  PRs that need a full CI run. 
  
    semver-minor
  PRs that contain new features and should be released in the next minor version. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This was forgotten in: #43586
Ref: nodejs/nodejs.org#4713
This commit adds a new command line option named
'--openssl-shared-config' intended to allow reverting to the old OpenSSL
configuration behavior where Node.js would use the configuration section
name (called appname in OpenSSL) 'openssl_conf' which could potentially
be used my other applications..
PR-URL: #43124
Refs: #40366
Reviewed-By: James M Snell [email protected]
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Beth Griggs [email protected]